Czesc Ewa, sorry for the delay…
The inconsistency in “Disposal” Journal Entry names, is between differents areas of FA GUI.
When manually creating a Journal Set (in the GUI), we see “604-x {Asset Type} Disposal”:
But, when viewing or creating Accounting Categories for Capital Assets, via “Settings”, the Disposal code 604 is named “Disposal of Capital Asset”:
Right now, we’re retrieving Accounting Categories without using sub_classes, to test our app User input, as this works reliably with both simple journal entries (with just one attribute, eg. “Rent”) and also user-centric journal entries (eg. “Dividend” + “User”), and, realistically, these are the most likely use cases.
But, with Capital Assets, we can query the Accounting Categories without sub_classes, and can we then create Journal Entries using those Accounting Categories + Capital Asset Type. But, if an existing Journal Set is queried, there is no mechanism to return back “Category” and “Capital Asset Type” as two attributes via the API. Anyway, I think you understand the point, here. I accept, to change API behaviour would be not backwards compatible, so something like:
GET https://api.freeagent.com/v2/journal_sets?sub_accounts=false
could be used to force separate fields when coming out, and not upset legacy Asset-related Journal Entry API users. It’s also consistent with the API syntax around Categories.
Anyway, I think we concluded this thread. Over to FA Dev’s to review usage stats, and ponder the best solution… //Greg